Svelte-runtime-warpper #4744
Open
Svelte-runtime-warpper #4744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Restructured the layout_engine_atoms package to improve organization and clarity. - Introduced a new catalog module to manage atom presets and default atoms. - Added Vue-specific runtime components for rendering layout-engine manifests. - Implemented a ManifestApp class to serve manifests and static assets via ASGI. - Created Vue client assets including HTML, JavaScript, and CSS for the dashboard. - Developed various atom renderers for metrics, charts, and tables. - Added tests for the Vue runtime to ensure correct manifest serving and asset handling.
- Introduced `generate_manifest.py` to build and persist the dashboard manifest for the Vue example. - Updated Vue runtime to support dynamic loading of client assets and improved error handling. - Created `package.json` for the Vue client with necessary scripts and dependencies. - Implemented atom renderers in `atom-renderers.js` for rendering various dashboard tiles. - Refactored `atoms.js` to utilize the new atom renderers and cleaned up unused code. - Enhanced `main.js` to initialize the dashboard application with improved manifest fetching logic. - Added `runtime-core.js` to encapsulate the core runtime logic for the Vue application. - Created a new `runtime.js` file to export the layout engine's main functionalities. - Configured Vite for building the Vue client with appropriate settings for library output.
…hat spin up ManifestApp with the packaged assets.
…e and Vueatom registry
…log with Swarma-specific features
… include development suffix; enhance manifest schema and add new authoring helpers
…lities for layout-engine atoms
…d layout engine support
…ks for improved theming and navigation
…ates and enhance manifest with new channels
…ance manifest structure for mission control updates
…omponents and utilities
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+21
to
+44
| const push = (pageId: string) => { | ||
| const route = site.navigate(pageId); | ||
| if (!route) return; | ||
| state.currentPath = route; | ||
| if (options.onNavigate) { | ||
| options.onNavigate(route); | ||
| } else { | ||
| window.history.pushState({}, "", route); | ||
| } | ||
| }; | ||
|
|
||
| window.addEventListener("popstate", () => { | ||
| state.currentPath = window.location.pathname; | ||
| }); | ||
|
|
||
| watch( | ||
| () => state.currentPath, | ||
| (next) => { | ||
| console.debug("Shell route changed", next); | ||
| } | ||
| ); | ||
|
|
||
| return state; | ||
| } |
There was a problem hiding this comment.
Within createShellRouter a push function is declared to update the active page and browser history, but the returned value from the factory is only the reactive ShellRoute state. Callers therefore have no way to trigger navigation, so pressing buttons that call push from outside this file is impossible and the router state never changes except through popstate events. The function should be returned (or attached to the state object) so consumers can programmatically navigate.
Useful? React with 👍 / 👎.
…-svelte_dashboard Add fallback rendering for Svelte dashboard example
…-svelte_dashboard-ntm22s
…-svelte_dashboard-ntm22s Render Svelte dashboard demo via fallback widgets
…dating Svelte version in import map. Implement fallback invocation logic to prevent multiple triggers during rendering.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.