Remove the options object from decodeLocation

swan-io · Jan 2, 2024 · e5eb670 · e5eb670
1 parent 095f0aa
commit e5eb670
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/__tests__/location.ts b/__tests__/location.ts
@@ -4,12 +4,9 @@ import { decodeLocation } from "../src/history";
 const getEqual =
   (removeExtraPathSlashes: boolean) =>
   <E>(path: string, sanitized: string, location: E) => {
-    const { toString, ...value } = decodeLocation(path, {
-      removeExtraPathSlashes,
-    });
-
-    expect(toString()).toStrictEqual(sanitized);
+    const { toString, ...value } = decodeLocation(path, removeExtraPathSlashes);
     expect(value).toStrictEqual(location);
+    expect(toString()).toStrictEqual(sanitized);
   };
 
 test("decodeLocation parses well-formed paths properly", () => {

diff --git a/src/history.ts b/src/history.ts
@@ -13,7 +13,7 @@ let initialLocationHasChanged = false;
 
 export const decodeLocation = (
   url: string,
-  { removeExtraPathSlashes = false }: { removeExtraPathSlashes?: boolean } = {},
+  removeExtraPathSlashes = false,
 ): Location => {
   const route = parseRoute(url);
   const path = route.path.substring(1);
@@ -54,7 +54,7 @@ export const createBrowserHistory = () => {
 
   let currentLocation = decodeLocation(
     globalLocation.pathname + globalLocation.search,
-    { removeExtraPathSlashes: true },
+    true,
   );
 
   const maybeUpdateLocation = (nextLocation: Location) => {