Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI: add support for Polling Endpoint Consumers #1833

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

CLI: add support for Polling Endpoint Consumers #1833

wants to merge 2 commits into from
+17 −2

Conversation

svix-onelson
Copy link
Contributor

@svix-onelson svix-onelson commented Mar 20, 2025 •
edited
Loading

Adds support for using v1.events-public.consumer and v1.events-public.consumer-seek, but gated behind a svix_beta cargo feature.

@svix-onelson svix-onelson force-pushed the onelson/poller-consumer-cli branch from 3335022 to 676c209 Compare March 20, 2025 23:13
@svix-onelson
CLI: add support for Polling Endpoint Consumers
c26e0cc 
Adds support for using `v1.events-public.consumer` and
`v1.events-public.consumer-seek`, but gated behind a `svix_beta`
cargo feature.
@svix-onelson svix-onelson force-pushed the onelson/poller-consumer-cli branch from 676c209 to c26e0cc Compare March 20, 2025 23:14
@svix-onelson svix-onelson changed the base branch from onelson/libs-add-polling-consumer to onelson/poller-consumer-redux March 20, 2025 23:28
@svix-onelson svix-onelson changed the base branch from onelson/poller-consumer-redux to onelson/libs-add-polling-consumer March 20, 2025 23:28
@svix-onelson svix-onelson marked this pull request as ready for review March 21, 2025 02:12
@svix-onelson svix-onelson requested a review from a team as a code owner March 21, 2025 02:12
svix-mman
svix-mman previously approved these changes Mar 21, 2025
View reviewed changes
@svix-gabriel
Copy link
Contributor

We should probably rename the endpoint to something like stream_events, if that's not already taken? IIRC public_events was just the chosen name because we didn't know what to name it at the time.

@svix-onelson
Copy link
Contributor Author

We should probably rename the endpoint to something like stream_events, if that's not already taken? IIRC public_events was just the chosen name because we didn't know what to name it at the time.

Yeah, this is specifically why I only exposed this in the rust client and only behind the svix_beta flag. The name right now is not great, even with the historical context.

Base automatically changed from onelson/libs-add-polling-consumer to main March 21, 2025 21:04
@svix-onelson svix-onelson dismissed svix-mman’s stale review March 21, 2025 21:04

The base branch was changed.

@svix-onelson svix-onelson requested review from svix-mman and a team March 21, 2025 21:34
@svix-onelson svix-onelson requested a review from a team March 21, 2025 21:51
@svix-onelson
Copy link
Contributor Author

Looks like @svix-mman is not yet a code owner here 🤔

@svix-mman
Copy link
Contributor

Looks like @svix-mman is not yet a code owner here 🤔

I think it's because I pushed the fix for cargo fix, so it ignores my review 🤷

@svix-onelson
Copy link
Contributor Author

Oh! I didn't realize you pushed to my branch. I thought you merged that to main.

@svix-mman
Copy link
Contributor

Oh! I didn't realize you pushed to my branch. I thought you merged that to main.

My apologizes, I guess it's was not the correct etiquette. 😓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svix-mman svix-mman svix-mman approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@svix-onelson @svix-gabriel @svix-mman