Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python: Move OperationalWebhook to new codegen #1656

Conversation

svix-mman
Copy link
Contributor

And rename to OperationalWebhookEndpoint
This change was not done in #1646 because the openapi.json file was not ready.

Splitting this off from the main new HTTP client PR since I am also breaking some of the function arguments

@svix-mman svix-mman requested a review from a team as a code owner January 21, 2025 17:54
@svix-mman svix-mman force-pushed the mendy/switch-operational-webhook-to-new-codegen branch from fe67358 to 2018317 Compare January 21, 2025 19:13
@svix-mman
Copy link
Contributor Author

@svix-jplatte Do you think we should add a breaking change notice for the function params changing?

Copy link
Member

@svix-jplatte svix-jplatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which breaking change exactly? The parameter names / replacement of PostOptions / something else? The param names and PostOptions already have changelog entries, right? If so, let's just update those.

python/svix/api/operational_webhook_endpoint.py Outdated Show resolved Hide resolved
ChangeLog.md Outdated Show resolved Hide resolved
ChangeLog.md Outdated Show resolved Hide resolved
@svix-mman svix-mman merged commit db7adbe into mendy/add-python-low-level-http-client Jan 23, 2025
7 checks passed
@svix-mman svix-mman deleted the mendy/switch-operational-webhook-to-new-codegen branch January 23, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants