Skip to content

Ignore malformed style attributes in minifyStyles. #2054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Ignore malformed style attributes in minifyStyles. #2054

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions plugins/minifyStyles.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,9 +129,13 @@ export const fn = (_root, { usage, ...params }) => {
for (const node of elementsWithStyleAttributes) {
// style attribute
const elemStyle = node.attributes.style;
node.attributes.style = csso.minifyBlock(elemStyle, {
...params,
}).css;
try {
node.attributes.style = csso.minifyBlock(elemStyle, {
...params,
}).css;
} catch {
/** ignore style syntax errors */
}
}
},
},
Expand Down
13 changes: 13 additions & 0 deletions test/plugins/minifyStyles.12.svg.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
Ensure plugin works with syntactically incorrect style attributes.

===

<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 225 425">
<path style="fill- opacity:0.5" d="M0 50 l50 50 0 20z"/>
</svg>

@@@

<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 225 425">
<path style="fill- opacity:0.5" d="M0 50 l50 50 0 20z"/>
</svg>