Skip to content

fix: only re-run directly applied attachment if it changed #15962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 20, 2025

Conversation

Rich-Harris
Copy link
Member

alternative to #15948 — instead of warning that it might not work as expected, we can just make it work as expected.

This doesn't address the similar issue for spread attributes (#15949, #15961) but it seems like a no-brainer for direct attachments on elements.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented May 20, 2025

🦋 Changeset detected

Latest commit: 2b13874

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot
Copy link

Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@15962

@Rich-Harris
Copy link
Member Author

errrr i should have run the tests before pushing this i guess

@paoloricciuti
Copy link
Member

Makes absolute sense...I thought it was "reasonable" to rerun in legacy mode since the whole object was invalidated but since attachments are brand new and this is the expected behavior it's way better

@Rich-Harris Rich-Harris merged commit 93443f9 into main May 20, 2025
13 checks passed
@Rich-Harris Rich-Harris deleted the stable-attachments-legacy branch May 20, 2025 15:13
@github-actions github-actions bot mentioned this pull request May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants