-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
fix: warn on bidirectional control characters, fix various issues with template expressions #15893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: cc7c317 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
It's always a good idea to fix separate bugs in separate PRs — in particular, if there are no tests then regressions are very likely |
I see, sorry for the issue. Should I remove the extra code from this PR? |
No need, the merge will take care of it! |
…paringly as it creates more git noise)
…s that they are composed of
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Closes #6890 by warning if any bidirectional control characters are found in:
Additionally, I found and fixed a minor bug in the
build_template_chunk
andprocess_children
functions where certain nullish expressions wouldn't be coallesced to an empty string. I also noticed that the partial evaluation evaluatesBigInt
calls, which could throw, so I fixed it. Since these are very small changes, I don't think they necessitate a separate PR.Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.packages/svelte/src
, add a changeset (npx changeset
).Tests and linting
pnpm test
and lint the project withpnpm lint