[fix] ignore css-unused-selector rule if <style global> #173
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #123
This PR detects if the style block contains the "global" attribute and filters "css-unused-selector" warnings if true.
The desired UX is to have the following code not emit an ESLint warning:
I added the
global-stylesample to test this.Run
yarn test; no errors should be emitted from theglobal-stylesample.Without this modification, running
yarn teston theglobal-stylesample would return the following warnings (expected):[ { "ruleId": "css-unused-selector", "severity": 1, "message": "Unused CSS selector \"h1\"", "line": 2, "column": 3, "endLine": 2, "endColumn": 5 } ]