feat: added the `prefer-svelte-reactivity` rule #1151

marekdedic · 2025-03-24T09:02:59Z

Blocked by eslint-community/eslint-utils#249

changeset-bot · 2025-03-24T09:03:03Z

🦋 Changeset detected

Latest commit: 586dca9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
eslint-plugin-svelte	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2025-03-24T09:04:25Z

Try the Instant Preview in Online Playground

ESLint Online Playground

Install the Instant Preview to Your Local

npm i https://pkg.pr.new/eslint-plugin-svelte@23c8253

Published Instant Preview Packages:

eslint-plugin-svelte: https://pkg.pr.new/eslint-plugin-svelte@23c8253

View Commit

baseballyama

I think we need to add tests for .svelte.js files also.

...lint-plugin-svelte/tests/fixtures/rules/prefer-svelte-reactivity/invalid/date01-input.svelte

marekdedic · 2025-03-24T09:39:26Z

I think we need to add tests for .svelte.js files also.

Yes, I wanted to ask about whether that's something we're set up to do, I couldn't find any such tests on the repo...

marekdedic · 2025-03-24T11:19:13Z

@ota-meshi Can you please take a look at the test file? I tried the solution from eslint-community/eslint-utils#249 (comment), but it didn't work for me :/

ota-meshi · 2025-04-30T07:41:11Z

@marekdedic What have you tried? Have you added URL here?

eslint-plugin-svelte/packages/eslint-plugin-svelte/tests/utils/utils.ts

Line 18 in 3ddbd83

const globals = {

marekdedic · 2025-05-03T10:15:05Z

@marekdedic What have you tried? Have you added URL here?

That's exactly what I tried, but it didn't work :(

ota-meshi · 2025-05-08T01:05:13Z

Is it url01-input.svelte that you're saying didn't work? I've tried adding URL: 'readonly', URLSearchParams: 'readonly' to globals in your repository and it seems to work fine.

marekdedic · 2025-05-08T14:09:39Z

Ok, I was adding it in a different place and the value got overriden, thanks :)

README.md

...lint-plugin-svelte/tests/fixtures/rules/prefer-svelte-reactivity/invalid/date01-input.svelte

packages/eslint-plugin-svelte/src/rules/prefer-svelte-reactivity.ts

marekdedic · 2025-06-09T15:42:46Z

I have re-implemented the PR so that it checks all the property calls and only reports if the variable is mutated.

ota-meshi

Awesome! Looks almost good to me, but I have two comments.

ota-meshi · 2025-06-09T23:44:38Z

packages/eslint-plugin-svelte/src/utils/ast-utils.ts

+	if (needle === haystack) {
+		return true;
+	}
+	if (needle.parent === undefined || needle.parent === null) {


I prefer to use == only in this case.

Suggested change

if (needle.parent === undefined || needle.parent === null) {

if (needle.parent == null) {

ota-meshi · 2025-06-09T23:49:37Z

packages/eslint-plugin-svelte/src/rules/prefer-svelte-reactivity.ts

+			[ReferenceTracker.READ]: true
+		}
+	})) {
+		if (node.parent.type === 'AssignmentExpression') {


I think we need to check if the node on the left.

Suggested change

if (node.parent.type === 'AssignmentExpression') {

if (node.parent.type === 'AssignmentExpression' && node.parent.left === node) {

If we don't check that, I think it will match x = url.hash.

marekdedic force-pushed the prefer-svelte-reactivity branch from d061a99 to 6999c90 Compare March 24, 2025 09:03

marekdedic force-pushed the prefer-svelte-reactivity branch 2 times, most recently from 5cede00 to f44a65c Compare March 24, 2025 09:25

baseballyama reviewed Mar 24, 2025

View reviewed changes

...lint-plugin-svelte/tests/fixtures/rules/prefer-svelte-reactivity/invalid/date01-input.svelte Outdated Show resolved Hide resolved

marekdedic force-pushed the prefer-svelte-reactivity branch from 7603712 to d1230de Compare May 3, 2025 10:11

marekdedic force-pushed the prefer-svelte-reactivity branch 6 times, most recently from 18dad7e to dcf3e34 Compare May 8, 2025 14:09

marekdedic marked this pull request as ready for review May 8, 2025 14:13

marekdedic requested a review from baseballyama May 8, 2025 14:13

ota-meshi reviewed May 8, 2025

View reviewed changes

README.md Outdated Show resolved Hide resolved

...lint-plugin-svelte/tests/fixtures/rules/prefer-svelte-reactivity/invalid/date01-input.svelte Outdated Show resolved Hide resolved

ota-meshi mentioned this pull request May 8, 2025

chore: use \ notation for line breaks in *.md #1215

Merged

marekdedic force-pushed the prefer-svelte-reactivity branch from dcf3e34 to 1319f62 Compare May 12, 2025 15:59

marekdedic force-pushed the prefer-svelte-reactivity branch 2 times, most recently from 30e17ee to 8e74c27 Compare May 28, 2025 16:00

marekdedic force-pushed the prefer-svelte-reactivity branch 2 times, most recently from 169791a to af1cb8f Compare June 7, 2025 08:32

ota-meshi reviewed Jun 7, 2025

View reviewed changes

packages/eslint-plugin-svelte/src/rules/prefer-svelte-reactivity.ts Outdated Show resolved Hide resolved

marekdedic force-pushed the prefer-svelte-reactivity branch from af1cb8f to 1689df3 Compare June 7, 2025 15:07

chore(prefer-svelte-reactivity): added tests

80e583d

marekdedic force-pushed the prefer-svelte-reactivity branch 8 times, most recently from 6aa464b to 23c8253 Compare June 9, 2025 15:34

marekdedic added 2 commits June 9, 2025 17:35

feat(prefer-svelte-reactivity): added rule implementation

11da03d

docs(prefer-svelte-reactivity): added rule docs

586dca9

marekdedic force-pushed the prefer-svelte-reactivity branch from 23c8253 to 586dca9 Compare June 9, 2025 15:36

marekdedic requested a review from ota-meshi June 9, 2025 15:41

marekdedic mentioned this pull request Jun 9, 2025

test: added support for .svelte.js test files #1244

Merged

ota-meshi requested changes Jun 9, 2025

View reviewed changes

	if (needle.parent === undefined \|\| needle.parent === null) {
	if (needle.parent == null) {

	if (node.parent.type === 'AssignmentExpression') {
	if (node.parent.type === 'AssignmentExpression' && node.parent.left === node) {

Uh oh!

feat: added the prefer-svelte-reactivity rule #1151

Are you sure you want to change the base?

feat: added the prefer-svelte-reactivity rule #1151

Uh oh!

Conversation

marekdedic commented Mar 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Mar 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

github-actions bot commented Mar 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Try the Instant Preview in Online Playground

Install the Instant Preview to Your Local

Published Instant Preview Packages:

Uh oh!

baseballyama left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

marekdedic commented Mar 24, 2025

Uh oh!

marekdedic commented Mar 24, 2025

Uh oh!

ota-meshi commented Apr 30, 2025

Uh oh!

marekdedic commented May 3, 2025

Uh oh!

ota-meshi commented May 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marekdedic commented May 8, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

marekdedic commented Jun 9, 2025

Uh oh!

ota-meshi left a comment

Choose a reason for hiding this comment

Uh oh!

ota-meshi Jun 9, 2025

Choose a reason for hiding this comment

Uh oh!

ota-meshi Jun 9, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

feat: added the `prefer-svelte-reactivity` rule #1151

feat: added the `prefer-svelte-reactivity` rule #1151

marekdedic commented Mar 24, 2025 •

edited

Loading

changeset-bot bot commented Mar 24, 2025 •

edited

Loading

github-actions bot commented Mar 24, 2025 •

edited

Loading

ota-meshi commented May 8, 2025 •

edited

Loading