Skip to content

feat(gemini): support types.Tool(google_maps=types.GoogleMaps()) #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Nov 4, 2025
Merged

feat(gemini): support types.Tool(google_maps=types.GoogleMaps()) #212

merged 13 commits into from
Nov 4, 2025
+595 −240

Conversation

@suurt8ll
Copy link
Owner

@suurt8ll suurt8ll commented Oct 24, 2025

@suurt8ll
refactor(gemini): move types.GenerateContentConfig building logic i…
c1a26f9 
…nto it's own method `Pipe._build_gen_content_config`
@suurt8ll suurt8ll linked an issue Oct 24, 2025 that may be closed by this pull request
feat(gemini): Google Maps Grounding #211
Closed
suurt8ll
suurt8ll commented Oct 24, 2025
View reviewed changes
Copy link
Owner Author

@suurt8ll suurt8ll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving the config building to it's own method makes it easier to add support for the map tool and potential future tools too.

suurt8ll added 12 commits October 25, 2025 09:19
@suurt8ll
feat(gemini): toggle filter for maps grounding
349337d
@suurt8ll
feat(gemini): MAPS_GROUNDING_COORDINATES valves option
1bdec57
@suurt8ll
feat(gemini): enable GoogleMaps tool when required
7645d03
@suurt8ll
fix(gemini): bump google-genai to 1.46.0
3bc65e4
@suurt8ll
fix(companion): get the source URI from GroundingChunkMaps correctly
af47183
@suurt8ll
fix(companion): don't resolve maps URIs
6254c20 
now only `https://vertexaisearch.cloud.google.com/grounding-api-redirect/` will be resolved
@suurt8ll
fix(companion): more general query emission message
89e5a5e 
maps tool  returns a query too and it would be incorrect to call it "Google Search"
@suurt8ll
feat(companion): include additional info about a source in it's "Cont…
471e8b5 
…ent" section.
@suurt8ll
fix(gemini): improve logs in Pipe._build_gen_content_config to debug …
098534d 
…#211
@suurt8ll
fix(gemini): more clear logs when handling the thinking options
91fa5a5
@suurt8ll
fix(gemini): log a warning when maps grounding toggle filter is not d…
44aad0a 
…etected
@suurt8ll
chore(gemini): log out even more info when checking toggleable filter…
8e2a5fe 
… status to pin down the issue #211
@suurt8ll suurt8ll marked this pull request as ready for review November 4, 2025 10:45
@suurt8ll suurt8ll merged commit b1571a5 into master Nov 4, 2025
10 checks passed
@suurt8ll suurt8ll deleted the 211-featgemini-google-maps-grounding branch November 4, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat(gemini): Google Maps Grounding

2 participants

@suurt8ll