feat(rootly): add On Event trigger for incident timeline events#3232
Closed
SolariSystems wants to merge 1 commit intosuperplanehq:mainfrom
Closed
feat(rootly): add On Event trigger for incident timeline events#3232SolariSystems wants to merge 1 commit intosuperplanehq:mainfrom
SolariSystems wants to merge 1 commit intosuperplanehq:mainfrom
Conversation
Add the On Event trigger that fires when incident timeline events are created or updated in Rootly. This enables workflows to react to new notes, annotations, and status changes on incidents. Configuration: - Events: incident_event.created, incident_event.updated (required) - 7 optional filters: visibility, event kind, incident status, severity, service, team, event source Output payload includes: id, event content, kind, visibility, occurred_at, created_at, user_display_name, and incident data. All filters are applied server-side after webhook signature verification, with case-insensitive matching. Service and team filters match against both name and slug fields. Includes 22 tests covering signature verification, event type filtering, all 7 optional filters, and combined filter behavior. Closes superplanehq#2820 Signed-off-by: Solari Systems <solari@solarisystems.dev> Signed-off-by: Solari Systems <solarisys2025@gmail.com>
|
You have run out of free Bugbot PR reviews for this billing cycle. This will reset on March 12. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
Collaborator
|
Closing it, duplicate of #3150 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the On Event trigger for the Rootly integration, enabling workflows to react when incident timeline events are created or updated.
incident_event.createdandincident_event.updatedwebhook eventsChanges
Backend:
on_event.go— Trigger implementation withOnEventConfiguration,HandleWebhook(signature verification + event type + optional filters),matchesEventFilters(case-insensitive matching, service/team match by name or slug)on_event_test.go— 22 tests: signature (3), JSON parsing (1), event type filtering (2), visibility (2), event kind (1), incident status (2), severity (1), service (2), team (1), combined filters (2), setup (4)example_data_on_event.json— Example webhook payloadexample.go— ExampleData for OnEventrootly.go— Register OnEvent in Triggers()Frontend:
on_event.ts— Trigger renderer with title/subtitle from event content, metadata display for filtersindex.ts— Register onEvent trigger rendererTest plan
go test ./pkg/integrations/rootly/... -count=1)go vetcleanCloses #2820