fix: resolve context canceled when reading HTTP response body (#3141)#3160
Open
hadzija7 wants to merge 1 commit intosuperplanehq:mainfrom
Open
fix: resolve context canceled when reading HTTP response body (#3141)#3160hadzija7 wants to merge 1 commit intosuperplanehq:mainfrom
hadzija7 wants to merge 1 commit intosuperplanehq:mainfrom
Conversation
…lanehq#3141) Signed-off-by: hadzija7 <hadzijasale@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Fixes the HTTP component failing with "failed to read response body: context canceled" despite successful requests. The component now completes reading the response body before the request context is canceled.
Why
When the HTTP component made requests to endpoints that return large or slowly-streaming responses, the request context was canceled via
defer cancel()immediately whenexecuteRequestreturned—beforeprocessResponsecould read the body. The 30s client timeout could also fire during body read. This caused the component to fail withcontext canceledeven when the server returned 200 OK.Closes #3141
How
executeRequestnow returns thecancelfunction to the caller instead of callingdefer cancel()internally. The caller deferscancel()only after the response is fully processed.