Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support pgvector v0.7.0+ #63

Merged
merged 5 commits into from
Dec 15, 2024
Merged

fix: support pgvector v0.7.0+ #63

merged 5 commits into from
Dec 15, 2024

Conversation

undo76
Copy link
Contributor

@undo76 undo76 commented Dec 11, 2024

I see that this configuration was introduced in pgvector 0.8.0. Adding a version check.

(pg8000.dbapi.ProgrammingError) {'S': 'ERROR', 'V': 'ERROR', 'C': '42602', 'M': 'invalid configuration parameter name "hnsw.iterative_scan"', 'D': '"hnsw" is a reserved prefix.', 'F': 'guc.c', 'L': '1259', 'R': 'find_option'}

@undo76 undo76 requested a review from lsorber December 11, 2024 09:46
lsorber
lsorber requested changes Dec 11, 2024
View reviewed changes
Copy link
Member

@lsorber lsorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor suggestions.

src/raglite/_database.py Outdated Show resolved Hide resolved
src/raglite/_database.py Outdated Show resolved Hide resolved
src/raglite/_database.py Outdated Show resolved Hide resolved
lsorber
lsorber requested changes Dec 11, 2024
View reviewed changes
Copy link
Member

@lsorber lsorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed one required change.

src/raglite/_database.py Show resolved Hide resolved
undo76
undo76 commented Dec 11, 2024
View reviewed changes
Copy link
Contributor Author

@undo76 undo76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the changes included. Ready to merge.

lsorber
lsorber reviewed Dec 11, 2024
View reviewed changes
Copy link
Member

@lsorber lsorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more comment about the caching.

src/raglite/_database.py Outdated Show resolved Hide resolved
lsorber
lsorber approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@lsorber lsorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lsorber lsorber changed the title fix: Conditional parameters in pgvector. fix: support pgvector 0.7.0+ Dec 15, 2024
@lsorber lsorber force-pushed the fix/ms-conditional-iterative-scan branch 2 times, most recently from 6eed9c2 to 60a79cc Compare December 15, 2024 10:49
@lsorber lsorber force-pushed the fix/ms-conditional-iterative-scan branch from 60a79cc to 7b05cb0 Compare December 15, 2024 10:50
@lsorber lsorber changed the title fix: support pgvector 0.7.0+ fix: support pgvector v0.7.0+ Dec 15, 2024
@lsorber lsorber merged commit 7ec9582 into main Dec 15, 2024
2 checks passed
@lsorber lsorber deleted the fix/ms-conditional-iterative-scan branch December 15, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsorber lsorber lsorber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@undo76 @lsorber