-
Notifications
You must be signed in to change notification settings - Fork 237
[ETHEREUM-CONTRACTS] make openzeppelin import path version specific #2058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Changelog ReminderReminder to update the CHANGELOG.md for any of the modified packages in this PR.
|
strange failure in autowrap package:
Relevant code in
Note how the previous The compile error could be solved by changing the paths to |
finding:
fails because from the perspective of the compiler, Ways to avoid this:
For projects using OZ v5, this type incompatibility cannot be avoided (regardless of this change happening or not). Possible workaround: cast to a type imported from v5. |
openzeppelin-contracts stable major version has been v5 for a while.
If a Solidity project using openzeppelin v5 also wants to use the Superfluid protocol, that can result in a conflict.
In order to make that less likely, and to prepare the migration to openzeppelin v5, we change the import path to explicitly contain v4.