Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ETHEREUM-CONTRACTS] update SuperTokenV1Library #2048

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from
Open

[ETHEREUM-CONTRACTS] update SuperTokenV1Library #2048

wants to merge 7 commits into from
+430 −53

Conversation

d10r
Copy link
Collaborator

@d10r d10r commented Dec 31, 2024 •
edited
Loading

  • Add createPoolWithCustomERC20Metadata
  • SuperTokenV1Library distribute / distributeFlow return actualAmount / actualFlowRate

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 31, 2024 •
edited by d10r
Loading

Changelog Reminder

Reminder to update the CHANGELOG.md for any of the modified packages in this PR.

  • CHANGELOG.md modified
  • Double check before merge

@d10r d10r marked this pull request as ready for review January 2, 2025 19:47
@d10r d10r requested a review from hellwolf as a code owner January 2, 2025 19:47
hellwolf
hellwolf reviewed Jan 7, 2025
View reviewed changes
packages/ethereum-contracts/CHANGELOG.md

### Changed
- Fixed deployment of SimpleForwarder (solved an issue which caused batch operation `OPERATION_TYPE_SIMPLE_FORWARD_CALL` to always revert)
- `SuperTokenV1Library.distributeFlow`: return `actualFlowRate`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it could be breaking change for some; I think I might have a few places doing assert(whateverreturningbool)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but that's an okay breaking change, since it's not at ABI level, and code will not compile for the new function signature if they relying on returning bool.

hellwolf
hellwolf approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@hellwolf hellwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider to update CHANGELOG to mark some of the changes BREAKING

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hellwolf hellwolf hellwolf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d10r @hellwolf