Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump solc version to 0.8.23, update nix flake and update dependencies #1783

Merged
merged 11 commits into from
Feb 8, 2024

Conversation

0xdavinchee
Copy link
Contributor

@0xdavinchee 0xdavinchee commented Jan 18, 2024

How to review the PR:

  • SuperfluidToken.sol uses new emit IERC20.Transfer and removes EventsEmitter library
  • EventsEmitter lib removed
  • Skim most files to see 0.8.19 => 0.8.23
  • .sol files should not be interface
  • foundry.toml files updated
  • hardhat.config.ts files updated
  • truffle.config.js files updated

closes #1530

@0xdavinchee 0xdavinchee self-assigned this Jan 18, 2024
@0xdavinchee 0xdavinchee requested review from hellwolf, kasparkallas and a team as code owners January 18, 2024 10:33
Copy link

Changelog Reminder

Reminder to update the CHANGELOG.md for any of the modified packages in this PR.

  • CHANGELOG.md modified
  • Double check before merge

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (80099ac) 74.26% compared to head (ff4c979) 89.51%.

Additional details and impacted files
@@             Coverage Diff             @@
##              dev    #1783       +/-   ##
===========================================
+ Coverage   74.26%   89.51%   +15.25%     
===========================================
  Files         110      109        -1     
  Lines        5886     5885        -1     
  Branches      216      216               
===========================================
+ Hits         4371     5268      +897     
+ Misses       1463      565      -898     
  Partials       52       52               
Flag Coverage Δ
ethereum-contracts 97.20% <100.00%> (+31.74%) ⬆️
sdk-core 82.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hellwolf
Copy link
Contributor

@0xdavinchee let's wait until GDA rollouts?

@hellwolf hellwolf changed the title bump solc version to 0.8.23 Bump solc version to 0.8.23, update nix flake and update dependencies Feb 7, 2024
Copy link
Contributor

@hellwolf hellwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog update then we are fine.

@hellwolf hellwolf enabled auto-merge February 8, 2024 09:20
@hellwolf hellwolf added this pull request to the merge queue Feb 8, 2024
Merged via the queue into dev with commit 6d74a1c Feb 8, 2024
21 checks passed
@hellwolf hellwolf deleted the bump-solc-version branch February 8, 2024 11:24
Copy link

github-actions bot commented Feb 8, 2024

XKCD Comic Relif

Link: https://xkcd.com/1783
https://xkcd.com/1783

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ETHEREUM-CONTRACTS] Update to Solidity 0.8.23
2 participants