[PUBLISH] Push items directly to publish queue when possible. #2803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch add a `publish:push` command which directly put items to publish services queue without passing by the `published` collection. SDESK-7448
|
Note: This is currently a work in progress; I am not entirely sure how to handle the correct publishing workflow for this scenario. I will need to discuss it further with @MarkLark86 . |
The new "Pushed" state is use when an item is pushed directly to publishing services (without using `publish:enqueue`). `enqueue_published.apply_async()` has been removed from `BasePublishService.update`: Only scheduled items are not pushed within this method; they will be published at a later date, so triggering `enqueue_published` immediately is unnecessary. Tests have been updated. SDESK-7448
|
@MarkLark86 I've updated this PR following our discussion today. I'm keeping the Thanks! |
MarkLark86
approved these changes
Jan 17, 2025
I wouldn't worry about publishing working at the moment, I think there's a few more kinks in the chain we need to fix before async publishing works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch add a
publish:pushcommand which directly put items to publish services queue without passing by thepublishedcollection.SDESK-7448