Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Agenda preview to display multiple Events [STT-53] #1212

Merged
merged 8 commits into from
Dec 19, 2024
Merged

Update Agenda preview to display multiple Events [STT-53] #1212

merged 8 commits into from
Dec 19, 2024

Conversation

devketanpro
Copy link
Member

@devketanpro devketanpro commented Dec 17, 2024 •
edited
Loading

Purpose

Update Ui views to display, secondary link events, and planning.

What has changed

Steps to test

[UI Views]
image
image

Checklist

  • This pull request is not adding new forms that use redux
  • This pull request is adding missing TypeScript types to modified code segments where it's easy to do so with confidence
  • This pull request is replacing lodash.get with optional chaining for modified code segments

Resolves: #STT-53

MarkLark86
MarkLark86 reviewed Dec 18, 2024
View reviewed changes
assets/agenda/components/AgendaPreviewEvent.tsx Show resolved Hide resolved
assets/agenda/components/AgendaPreviewEvent.tsx Outdated Show resolved Hide resolved
assets/agenda/components/AgendaPreviewEvent.tsx Show resolved Hide resolved
assets/agenda/components/AgendaPreviewEvent.tsx Outdated Show resolved Hide resolved
assets/agenda/components/AgendaPreviewPlanning.tsx Outdated Show resolved Hide resolved
assets/agenda/components/AgendaPreviewPlanning.tsx Outdated Show resolved Hide resolved
assets/agenda/components/AgendaPreviewPlanning.tsx Outdated Show resolved Hide resolved
@tomaskikutis tomaskikutis removed their request for review December 18, 2024 10:46
MarkLark86
MarkLark86 reviewed Dec 18, 2024
View reviewed changes
Copy link
Contributor

@MarkLark86 MarkLark86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, just a couple small style improvements

assets/agenda/actions.ts Outdated Show resolved Hide resolved
assets/agenda/components/AgendaPreviewEvent.tsx Outdated Show resolved Hide resolved
assets/agenda/components/AgendaPreviewEvent.tsx Outdated Show resolved Hide resolved
@MarkLark86 MarkLark86 added this to the v3.1 milestone Dec 19, 2024
@devketanpro devketanpro merged commit 0c13b9c into superdesk:feature/multiple-events-in-planning Dec 19, 2024
8 checks passed
@devketanpro devketanpro deleted the STT-53 branch December 19, 2024 05:51
MarkLark86 pushed a commit to MarkLark86/newsroom-core that referenced this pull request Dec 20, 2024
@devketanpro @MarkLark86
Update Agenda preview to display multiple Events [STT-53] (superdesk#…
0242f36 
…1212)

* Update Agenda preview to display multiple Events [STT-53]

* minor chnage

* address comment

* refactore code

* fix lint

* format code

* update types
MarkLark86 pushed a commit to MarkLark86/newsroom-core that referenced this pull request Dec 20, 2024
@devketanpro @MarkLark86
Update Agenda preview to display multiple Events [STT-53] (superdesk#…
1ba1e4d 
…1212)

* Update Agenda preview to display multiple Events [STT-53]

* minor chnage

* address comment

* refactore code

* fix lint

* format code

* update types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkLark86 MarkLark86 MarkLark86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.1
Development

Successfully merging this pull request may close these issues.
2 participants
@devketanpro @MarkLark86