Fix broken bash shell completion (#12)

* Update the minimum Click version from `8.1.3` to `8.1.7`

* Remove patch for Click Bash completion

Introduced in #11. See #10.

pyproject.toml

@@ -32,7 +32,7 @@ include = ["generate_completions.sh", "tldr-man.1"]
 
 [tool.poetry.dependencies]
 python = "^3.10.4"
-click = "^8.1.3"
+click = "^8.1.7"
 click-help-colors = "^0.9.1"
 requests = "^2.28.1"
 

src/tldr_man/main.py

@@ -35,15 +35,12 @@
 from click_help_colors import HelpColorsCommand
 
 from tldr_man import pages
-from tldr_man.shell_completion import page_shell_complete, language_shell_complete, patch_bash_completion
+from tldr_man.shell_completion import page_shell_complete, language_shell_complete
 from tldr_man.languages import get_locales
 from tldr_man.platforms import get_page_sections, TLDR_PLATFORMS
 from tldr_man.util import unique, mkstemp_path
 
 
-patch_bash_completion()  # See issue #10
-
-
 def standalone_subcommand(func):
     """Function decorator to reduce boilerplate code at the start and end of all subcommand callback functions."""
     @wraps(func)

src/tldr_man/shell_completion.py

@@ -44,12 +44,3 @@ def language_shell_complete(_ctx: Context, _param: Parameter, _incomplete: str)
     if not CACHE_DIR.exists():
         return []
     return [CompletionItem(code) for code in all_language_codes()]
-
-
-def patch_bash_completion():
-    """
-    Patches click Bash shell completion generation to not raise an error on generating for Bash versions older than 4.4.
-
-    Fixes <https://github.com/superatomic/tldr-man/issues/10>, <https://github.com/pallets/click/issues/2574>.
-    """
-    BashComplete._check_version = lambda _: None