fix(storage): add query parameters option to download #1327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 20076663237Details
💛 - Coveralls |
grdsdev
approved these changes
Dec 9, 2025
Contributor
grdsdev
left a comment
grdsdev
left a comment
There was a problem hiding this comment.
Approved, do we have tests for this?
Contributor
Author
Just merged two tests to ensure this behavior is maintained going forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Adds a query parameters argument to
downloadmethod of storage client. This is done because the docs on storage advice the user to bypass caching by setting a unique query parameter on the url (relevant link). However, since we started using the URL builders, the client has been (correctly) ignoring any passed in query parameters for that function, so that was not possible to do.