-
-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Dispose supabase client after flutter web hot-restart #1142
Open
Vinzent03
wants to merge
8
commits into
main
Choose a base branch
from
fix/web-hot-restart
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
599ddc3
to
9f3066b
Compare
Pull Request Test Coverage Report for Build 14173380797Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
WebSocket and braodcast channel connections are not closed when Flutter is hot-restarted on web.
This causes old dart code that is still associated with the WebSocket connection to be still running and causes unexpected behavior like type errors and the fact that the events of the old connection may still be logged.
What is the new behavior?
I'm storing a function in js to disconnect the previous supabase client.
I further noticed that the
longtimerPollerTimeout
was never actually used, becausestream.timeout()
returns a new stream with that timeout, but doesn't change the actually stream that timeout is called on. This could easily be fixed, but I found no usage of such timeout in realtime-js in a quick search, so I removed it instead.I as well noticed that the broadcast channel didn't work, so I fixed the migration from #1135
Additional context
I worked a lot to find the cause for #1126, and I noticed that the event and code that is causing the type error is old code after a hot-restart. So I tried to solve #1088 and I think I succeeded. I'm no longer seeing the error from #1126 now.close #1088