feat(templatemailer): getPath function should append existing query strings instead of overwrite #2194
+14
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…trings instead of overwrite
hf
reviewed
Oct 29, 2025
Comment on lines
505
to
510
| path.RawQuery = fmt.Sprintf("token=%s&type=%s&redirect_to=%s", url.QueryEscape(params.Token), url.QueryEscape(params.Type), encodeRedirectURL(params.RedirectTo)) | ||
|
|
||
| // If the path already has query params, append them | ||
| q := path.Query().Encode() | ||
| if q != "" { | ||
| path.RawQuery += fmt.Sprintf("&%s", q) |
Contributor
There was a problem hiding this comment.
Instead of string concatenation, this should build the query object instead.
Author
There was a problem hiding this comment.
By default Go alphabetically sorts the query parameters which causes other tests to fail. Even if I change that, using .Encode() encodes the redirect_to=https%3A%2F%2Fexample.com&..., again this also fails. I either need to change the tests in order to be compatible with the code. Nonetheless, I'll refactor this part a bit.
If you want me to change the tests as well and use query builder I can do that also.
dogukanakkaya
force-pushed
the
feat/get-path-should-append-existing-query-strings
branch
from
e9a6fd3 to
ad45617
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This is a bug fix for issue: supabase/supabase#36990
What is the current behavior?
If you change
ConfirmationURLfor an email tohttps://supabase.com?flow=testthe sent email will override theflow=testquery string and only add specified parameters.What is the new behavior?
New behavior fixes that and appends the whatever in the
ConfirmationURLafter the specified parameters.?token_hash=xxxx&email=xxxxxx&flow=test