Skip to content

fix: allow newlines in SMS/MFA OTP templates #2132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: allow newlines in SMS/MFA OTP templates #2132

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c938930
fix: allow newlines in SMS/MFA OTP templates (translate \n to newline…
DHANUSHRAJA22 Aug 25, 2025
b504b04
Merge pull request #1 from DHANUSHRAJA22/fix/sms-mfa-newlinefix/sms-m…
DHANUSHRAJA22 Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 21 additions & 21 deletions internal/conf/configuration.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -945,34 +945,34 @@
}

if config.Sms.Provider != "" {
SMSTemplate := config.Sms.Template
if SMSTemplate == "" {
SMSTemplate = "Your code is {{ .Code }}"
}
template, err := template.New("").Parse(SMSTemplate)
if err != nil {
return err
}
config.Sms.SMSTemplate = template
}
SMSTemplate := strings.ReplaceAll(config.Sms.Template, "\\n", "\n")
if SMSTemplate == "" {
SMSTemplate = "Your code is {{ .Code }}"
}
template, err := template.New("").Parse(SMSTemplate)
if err != nil {
return err
}
config.Sms.SMSTemplate = template

if config.MFA.Phone.EnrollEnabled || config.MFA.Phone.VerifyEnabled {
smsTemplate := strings.ReplaceAll(config.MFA.Phone.Template, "\\n", "\n")
if smsTemplate == "" {
smsTemplate = "Your code is {{ .Code }}"
}
template, err := template.New("").Parse(smsTemplate)
if err != nil {
return err
}
config.MFA.Phone.SMSTemplate = template
}

if config.MFA.Phone.EnrollEnabled || config.MFA.Phone.VerifyEnabled {
smsTemplate := config.MFA.Phone.Template
if smsTemplate == "" {
smsTemplate = "Your code is {{ .Code }}"
}
template, err := template.New("").Parse(smsTemplate)
if err != nil {
return err
}
config.MFA.Phone.SMSTemplate = template
}

return nil
}

// ApplyDefaults sets defaults for a GlobalConfiguration
func (config *GlobalConfiguration) ApplyDefaults() error {

Check failure on line 975 in internal/conf/configuration.go

View workflow job for this annotation

GitHub Actions / test 

syntax error: unexpected name error at end of statement

Check failure on line 975 in internal/conf/configuration.go

View workflow job for this annotation

GitHub Actions / test 

expected ';', found error
if config.JWT.AdminGroupName == "" {
config.JWT.AdminGroupName = "admin"
}
Expand Down
Loading