fix: initialize auth subclient with auth key token#53
Open
zugdev wants to merge 1 commit into
Open
Conversation
NewClient() creates the Auth sub-client via auth.New() but never calls WithToken(), so the Auth sub-client's internal requests lack the Authorization header. Chain .WithToken(key) in the initialization to match supabase-py's behavior where the API key serves as the initial bearer token until a user signs in. Fixes supabase-community#16
zugdev
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix, resolves #16
What is the current behavior?
NewClient()creates the Auth subclient but never callsWithToken(). The auth-go internalnewRequest()only sendsAuthorization: Bearerwhen the token field is non-empty, so the header is omitted (silently). Thus, any call to authenticated endpoints returns a 401.What is the new behavior?
Chain
.WithToken(key)onto the Auth client initialization.supabase-py does this in
_sync/client.pyline 325:Introduce
TestGetUserSendsAuthHeader(which is also a PoC of the previous behavior) verifies the header is sent using anhttptestmock server.Additional context
One-line change in
client.go. No breaking changes.