expose client error#44
Open
stevenctl wants to merge 2 commits into
Open
Conversation
Author
|
since the postgrest stuff merged i'll revert the go.mod stuff (or just bump it in this PR)? I see this project already relies on a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature
What is the current behavior?
There is no way to see error caused by methods such as
RpcWhat is the new behavior?
Simply passing through the ClientError field on the postrest client
Additional context
It might make sense to change certain method, or create variants of other methods that return
(something, error)that check this so callers don't need to understand whenClientErroris relevant to the specific call they want to make.