[OOB] warn on incomplete trace when graph replay kernels are skipped#105
Open
zejunchen-zejun wants to merge 1 commit into
Open
[OOB] warn on incomplete trace when graph replay kernels are skipped#105zejunchen-zejun wants to merge 1 commit into
zejunchen-zejun wants to merge 1 commit into
Conversation
Non-full modes silently drop batch AQL packets from HIP graph replay, producing a valid-looking trace that is missing graph replay kernels. - Emit "WARNING: INCOMPLETE TRACE" to stderr when drop(batch skip) > 0 - Store rtl_mode/drop_batch_skip/trace_complete in rocpd_metadata - Surface incomplete trace warning in `rtl info` output - Add graph replay limitation note to README - Remove misleading 'default' mode alias from CLI - Deprecate RTL_MODE='default' with warning Co-Authored-By: Claude Opus 4 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #104
Non-full modes silently drop batch AQL packets from HIP graph replay, producing a valid-looking trace that is missing graph replay kernels.
rtl infooutputCC: @wuhuikx