Skip to content

fixed issue #269: changed the colour of header bar for light mode in … #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Anuragreat wants to merge 1 commit into from
Closed

fixed issue #269: changed the colour of header bar for light mode in … #271

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/sunpy_sphinx_theme/theme/sunpy/static/sunpy_style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ html[data-theme="light"] {
/* A lot of these colors we have inherited from pst however, I have copied them all */
/* in here to make it obvious which colors are in use, and to shield us from any */
/* upstream changes. */
/* changed the colour on surface for light mode */
Copy link
Copy Markdown
Member

@nabobalis nabobalis Aug 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/* changed the colour on surface for light mode */

--pst-color-accent-bg: #f8dff5;
--pst-color-accent: var(--sst-accent-color-bright);
--pst-color-attention-bg: var(--pst-color-warning-bg);
Expand All @@ -75,7 +76,7 @@ html[data-theme="light"] {
--pst-color-link-hover: var(--sst-accent-color-muted);
--pst-color-link: var(--sst-accent-color-bright);
--pst-color-on-background: #fff;
--pst-color-on-surface: #222832;
--pst-color-on-surface: #a2a2a0;
Copy link
Copy Markdown
Member

@nabobalis nabobalis Aug 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change doesnt seem to have worked for me?

Copy link
Copy Markdown
Author

@Anuragreat Anuragreat Aug 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought the issue was about the dark colour of header in light mode..
So i changed the colour parameter to light

Copy link
Copy Markdown
Member

@nabobalis nabobalis Aug 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is the color of the mobile menu icons are black on the light theme

--pst-color-primary-bg: #d0ecf1;
--pst-color-primary: var(--sst-accent-color-bright);
--pst-color-secondary-bg: #e0c7ff;
Expand Down