Quick fix to breaking bug from thermal model #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mal model. Real issue is in thermal model which the testing energy range in the fitter fails on. Changed testing energy range to not get caught in thermal function bug.
Why do I always forget a changeling file!?
DanRyanIrish
approved these changes
Feb 20, 2024
samaloney
approved these changes
Feb 20, 2024
* Move CI to GitHub Actions * Get tests running * Add change log.
* Changed fittter_legacy module to fitting_legacy and added new fitting module --------- Co-authored-by: Kristopher Cooper <[email protected]> Co-authored-by: Shane Maloney <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #134 +/- ##
=======================================
Coverage ? 55.81%
=======================================
Files ? 20
Lines ? 3166
Branches ? 0
=======================================
Hits ? 1767
Misses ? 1399
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When changing the chianti file for the thermal model, the fitter test on the user model can fail. Real issue is in thermal model which the testing energy range in the fitter fails on. This PR changes testing energy range to not get caught in thermal function bug.
This is a quick fix which does not get at the real issue; however, it avoids the bug now and stops the fitter from breaking as described in #99. Additionally, this issue will be more fully dealt with during more refactoring of the package.