Merged
Conversation
…r other state variables --- Use context to pass savedLayout state variable and setter between Maker and SignIn components Ensure the savedLayouts array does not have undefined values when writing to firestore document
…yout, SaveLayout, and CourseGrid - Might also be able to eliminate other types, used by function returns
…ay vertically centered
…e info isn't consistent
…t keys do not remain in order after deserialization from Firestore
…hing text to pass
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Owner
Author
|
lgtm, If all tests pass and you have also made code improvements, then great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main change
I use Firestore from Firebase to save and load data by signing in to a Google account. Local storage (browser cache) still works, but cloud data is prioritized.
Other change made to support main change
I also eliminated unnecessary prop drilling in Maker, replacing it with context from Layout which also allows other components (specifically Signin in Navbar) to have access to data.