Skip to content

fix: limit admin bypass to DM routing #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
uncooldog wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: limit admin bypass to DM routing #173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ npm test
| 配置项 | 类型 | 必填 | 说明 |
| --- | --- | --- | --- |
| `channels.wecom.dynamicAgents.enabled` | boolean | 否 | 是否启用动态 Agent，默认 `true` |
| `channels.wecom.dynamicAgents.adminBypass` | boolean | 否 | 管理员是否绕过动态 Agent，默认 `false` |
| `channels.wecom.dynamicAgents.adminBypass` | boolean | 否 | 管理员私聊是否绕过动态 Agent，默认 `false`；群聊不受此项影响，仍按群路由 |
| `channels.wecom.dm.createAgentOnFirstMessage` | boolean | 否 | 私聊是否按用户建独立 Agent，默认 `true` |
| `channels.wecom.groupChat.enabled` | boolean | 否 | 是否启用群聊处理，默认 `true` |
| `channels.wecom.groupChat.requireMention` | boolean | 否 | 群聊是否要求 @ 才响应，默认 `true` |
Expand Down
2 changes: 1 addition & 1 deletion dynamic-agent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ export function shouldUseDynamicAgent({ chatType, config, senderIsAdmin = false
if (!dynamicConfig.enabled) {
return false;
}
if (senderIsAdmin && dynamicConfig.adminBypass) {
if (chatType === "dm" && senderIsAdmin && dynamicConfig.adminBypass) {
return false;
}
if (chatType === "group") {
Expand Down
13 changes: 13 additions & 0 deletions tests/dynamic-agent.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,19 @@ describe("shouldUseDynamicAgent", () => {
});
assert.equal(useDynamic, true);
});

it("keeps group routing on the group agent for admin when adminBypass is enabled", () => {
const config = {
dynamicAgents: { enabled: true, adminBypass: true },
groupChat: { enabled: true },
};
const useDynamic = shouldUseDynamicAgent({
chatType: "group",
config,
senderIsAdmin: true,
});
assert.equal(useDynamic, true);
});
});

describe("extractGroupMessageContent", () => {
Expand Down