Refactor 3D scene into createStandScene(config)#35
Conversation
…k-in-rule-engine Add collision-aware transforms and playground
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const surfaces = mAny.wallSurfaces || {}; | ||
|
|
||
| const backSurface = wallMaterial(surfaces.back ?? "system"); | ||
| const leftSurface = wallMaterial(surfaces.left ?? "system"); | ||
| const rightSurface = wallMaterial(surfaces.right ?? "system"); |
There was a problem hiding this comment.
Walls are now skinned from mAny.wallSurfaces, but the config/UI stores wall finishes in modules.wallsDetail (see ConfiguratorPanel). Because nothing writes wallSurfaces, every wall falls back to wallMaterial(..."system"), so user‑selected wood/banner/LED surfaces no longer render in 3D. This affects any stand with customized wall finishes.
Useful? React with 👍 / 👎.
sundsoffice-tech
force-pushed
the
main
branch
from
2ffcd93 to
3945a8c
Compare
1 participant
Summary
createStandScenefactory that builds a three.js scene, camera, and reusable stand objects from a configConfigurator3Dto source floor, wall, truss, and legacy counter/screen rendering from the generated scene objectsTesting
Codex Task