Add keyboard nudging and limit movable objects#3
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| storedHeight !== undefined && storedHeight > wallHeight + floorHeight | ||
| ? storedHeight - floorHeight | ||
| : storedHeight; | ||
| const heightFromFloor = | ||
| normalizedHeightFromFloor ?? |
There was a problem hiding this comment.
Legacy screen heights double-add floor offset
The new normalisation only subtracts floorHeight when heightFromFloor exceeds wallHeight + floorHeight, which misses legacy data where heightFromFloor already included the floor offset (previous converter stored floorHeight + 1.6). For raised floors, those stored values (e.g. 1.8 when floorHeight is 0.2) fall below the threshold, so heightFromFloor stays absolute and the worldY = floorHeight + heightFromFloor calculation just below adds the floor offset a second time. Any saved configuration from the previous version with a raised floor will render and drag screens too high by exactly the floor height, breaking layout and nudging accuracy until the user manually repositions them.
Useful? React with 👍 / 👎.
Summary
Testing
Codex Task