Skip to content

Add keyboard nudging and limit movable objects#3

Open
sundsoffice-tech wants to merge 1 commit into
mainfrom
codex/update-object-movement-and-selection-logic-uillar
Open

Add keyboard nudging and limit movable objects#3
sundsoffice-tech wants to merge 1 commit into
mainfrom
codex/update-object-movement-and-selection-logic-uillar

Conversation

@sundsoffice-tech

Copy link
Copy Markdown
Owner

Summary

  • add arrow-key nudging for selected cabin, counter, screen, and truss selections with per-mount axis clamping
  • cap detailed counter and screen counts (including legacy conversions) to prevent scene overload
  • keep ground-plane items locked to the stand footprint when nudged via keyboard

Testing

  • npm run build

Codex Task

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +1090 to +1094
storedHeight !== undefined && storedHeight > wallHeight + floorHeight
? storedHeight - floorHeight
: storedHeight;
const heightFromFloor =
normalizedHeightFromFloor ??

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Legacy screen heights double-add floor offset

The new normalisation only subtracts floorHeight when heightFromFloor exceeds wallHeight + floorHeight, which misses legacy data where heightFromFloor already included the floor offset (previous converter stored floorHeight + 1.6). For raised floors, those stored values (e.g. 1.8 when floorHeight is 0.2) fall below the threshold, so heightFromFloor stays absolute and the worldY = floorHeight + heightFromFloor calculation just below adds the floor offset a second time. Any saved configuration from the previous version with a raised floor will render and drag screens too high by exactly the floor height, breaking layout and nudging accuracy until the user manually repositions them.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant