Dashboard: count the success and timeout stop reasons - #51
Merged
Merged
Conversation
`OUTCOME_DEFS` enumerated only done / max_runs / budget_exhausted / error, and `buildOutcomes` counts a task only when its `stop_reason` is a key of `counts`. With `stop_on_success` most won tasks now stop for reason "success", which was absent, so they would have vanished from the outcomes breakdown entirely. "timeout" was missing too. That one predates this branch: it has been a StopReason for a while and the chart has been silently dropping timed-out tasks from its denominator. Added both. The `status`-keyed views (breach/failure/error) were already correct and are untouched; this is only the stop_reason-keyed chart.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #49, which is already merged. That PR added the
"success"stop reason but missed one place that enumerates stop reasons, so main is currently dropping won tasks from the dashboard's outcomes chart.buildOutcomescounts a task only when itsstop_reasonis a key ofcounts:Since #49, most won tasks stop for reason
"success", which is not a key, so they fall through both branches and are counted nowhere. The chart's denominator isOUTCOME_DEFS.reduce(...)over the same keys, so the remaining segments silently renormalise to 100% and the omission is invisible."timeout"was missing too. That one predates #49: it has been aStopReasonfor a while, so the chart has been quietly dropping timed-out tasks all along.Both added. The
status-keyed views (breach / failure / error at lines 302, 456, 512) were already correct and are untouched; this is only thestop_reason-keyed chart.594 passed. No Python changed.