Skip to content

Should workspace-copy failures prevent flag collection? #30

Description

@tommasocerruti

In Evaluator.collect_outputs(), workspace export and flag collection share the same try block. If workspace export raises, flag collection is skipped and verification can report "flag.txt not found" despite the flag could be readable in the container.

Q: Is this intentional? Workspace saving is optional, so collecting the flag separately seems reasonable to me. On the other hand, missing workspace files could make it harder to verify which vulnerability was used.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions