Move close button label translations inside the Dialog component #2871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 12c73b4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sirineJ
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2871 +/- ##
=======================================
Coverage 88.12% 88.12%
=======================================
Files 228 228
Lines 13186 13188 +2
Branches 1809 1809
=======================================
+ Hits 11620 11622 +2
Misses 1512 1512
Partials 54 54
|
connor-baer
reviewed
Jan 16, 2025
.changeset/spicy-avocados-provide.md
Outdated
| "@sumup-oss/circuit-ui": minor | ||
| --- | ||
|
|
||
| Refactored the Modal, Popover, Toggletip, and DateInput components to leverage the low-level Dialog component for improved consistency and maintainability. |
There was a problem hiding this comment.
We can already use our new terminology here:
Suggested change
| Refactored the Modal, Popover, Toggletip, and DateInput components to leverage the low-level Dialog component for improved consistency and maintainability. | |
| Refactored the Modal, Popover, Toggletip, and DateInput components to leverage the internal Dialog component for improved consistency and maintainability. |
There was a problem hiding this comment.
Should we also mention the SidePanel and SideNavigation components here?
sirineJ
force-pushed
the
feat/DSYS-900/dialog-close-button-label
branch
from
305252d to
48bc19e
Compare
|
Size Change: -6.13 kB (-0.9%) Total Size: 675 kB
ℹ️ View Unchanged
|
sirineJ
force-pushed
the
feat/DSYS-900/dialog-close-button-label
branch
from
48bc19e to
12c73b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses DSYS-900
Purpose
The Modal, DateInput, Toggletip and Popover components have been refactored using the Dialog component. All these components have a modal view that requires a close button label, that they provide the Dialog component with.
Approach and changes
Definition of done