[WIP] Timeline (random play) config dialog #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Looking good! I think we need the per-effect random settings definitely, at least for the flickr effect search term. For the others not necessarily, since then we would also need to be able to save and restore those settings... that's probably too much work... |
suluke
changed the title
suluke
force-pushed
the
feature/timeline-settings
branch
from
41d2a56 to
6d00ce3
Compare
This will eventually fix #68
suluke
force-pushed
the
feature/timeline-settings
branch
from
6d00ce3 to
c15d776
Compare
Owner
Author
|
Some current screenshots of this feature:
In the latter image we see that we still miss some categorization of the effects, e.g.:
We are also currently missing a functionality for the gear icons next to the effect titles. This should open another dialog to configure e.g. parameter ranges (particle max size/min size), a set of search terms (flickr) or image urls (change image). Needless to say that the necessary logic changes haven't even started. This is mostly UI so far |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do you think about the suggested ui, @luckyxxl ? What else do we need to make configurable?
The initial commit allows to select the effects that are randomized. Also, the ui contains hints that we can add per-effect randomization settings later. Not sure how this will look eventually, though.
This will eventually fix #68