[WIP] i18n #117
Open
[WIP] i18n #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a language picker component as well as a Localization- Manager class which keeps a list of managed DOM elements to be translated when the user changes the language. Only two locales (en_US and de_DE) have been added so far (json files) and they only contain localized strings for three small text components, so a lot of work still needs to be done. Also, dynamically adding new dom nodes to be localized by the LocalizationManager has not been used anywhere yet. This work is done to eventually implement #79
This does not include invisible texts (such as title attributes). This commit also moves the LocalePicker control into i18n.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an effort to implement #79, i.e. i18n functionality.
Roadmap: