Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to use preservation-client to do update #185

Merged
merged 1 commit into from
Jan 7, 2020

Conversation

jcoyne
Copy link
Contributor

@jcoyne jcoyne commented Jan 7, 2020

Why was this change made?

the Preservation-client provides an abstraction about how we talk to the preservation catalog. Additionally it has better error handling than we previously had here.

Fixes #182 and #183

Was the usage documentation (e.g. README, DevOpsDocs, wiki, queue specific README) updated?

n/a

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 97.966% when pulling 5ae87c7 on use-preservation-client into 353bd15 on master.

Copy link
Contributor

@ndushay ndushay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mjgiarlo mjgiarlo merged commit f6a1f76 into master Jan 7, 2020
@mjgiarlo mjgiarlo deleted the use-preservation-client branch January 7, 2020 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use preservation-client gem for pres-cat API calls from pres-robots
4 participants