Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update_catalog pres robots WF step should check the response from preservation #183

Open
jcoyne opened this issue Dec 18, 2019 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@jcoyne
Copy link
Contributor

jcoyne commented Dec 18, 2019

currently it only raises an error if the status is 400..599, but we aren't handling any redirect cases (e.g. 301), so we should ensure it's what we expect (e.g. 200) or raise an error.

https://github.com/sul-dlss/preservation_robots/blob/master/lib/robots/sdr_repo/preservation_ingest/update_catalog.rb#L47-L52

@ndushay
Copy link
Contributor

ndushay commented Dec 18, 2019

and indicate the WF step errored, and maybe even log this.

@ndushay ndushay changed the title Update catalog should check the response from preservation update_catalog pres WF step should check the response from preservation Dec 18, 2019
@ndushay ndushay changed the title update_catalog pres WF step should check the response from preservation update_catalog pres robots WF step should check the response from preservation Dec 19, 2019
@jcoyne jcoyne self-assigned this Dec 20, 2019
@jcoyne jcoyne removed their assignment Jan 7, 2020
@jcoyne
Copy link
Contributor Author

jcoyne commented Jan 7, 2020

@ndushay
Copy link
Contributor

ndushay commented Jul 6, 2022

reference to retriability of this step in #405 ... which may or may not be relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants