Change the default label for spotlight_upload_date_tesim #2354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default label for spotlight_upload_date_tesim was "Date", on the metadata configuration page (e.g. https://exhibits.stanford.edu/a11y-for-soda/metadata_configuration/edit), this has the same label as `date_ssim`, so an editor is unable to distinguish between the two. This overrides the Spotlight default so that we don't have two identical labels: https://github.com/projectblacklight/spotlight/blob/9c0ae85b1417c186a0dc49512ead23e9785331bf/config/locales/spotlight.en.yml#L812
jcoyne
commented
Sep 25, 2023
|
This works for new exhibits and exhibits that haven't changed the metadata, but unsure whether this would change exhibits that have customized the field label, or if we can even determine if they have. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default label for spotlight_upload_date_tesim was "Date", on the metadata configuration page (e.g. https://exhibits.stanford.edu/a11y-for-soda/metadata_configuration/edit), this has the same label as
date_ssim, so an editor is unable to distinguish between the two.This overrides the Spotlight default so that we don't have two identical labels: https://github.com/projectblacklight/spotlight/blob/9c0ae85b1417c186a0dc49512ead23e9785331bf/config/locales/spotlight.en.yml#L812