🚀(paas) add PaaS deployment scripts, tested on Scalingo #668
Conversation
|
| @@ -0,0 +1,7 @@ | |||
| #!/usr/bin/env python | |||
| """Setup file for the impress module. All configuration stands in the setup.cfg file.""" | |||
There was a problem hiding this comment.
| """Setup file for the impress module. All configuration stands in the setup.cfg file.""" | |
| """Setup file for the meet module. All configuration stands in the setup.cfg file.""" |
There was a problem hiding this comment.
is the addition of this file necessary for Scalingo?
https://setuptools.pypa.io/en/latest/userguide/pyproject_config.html
for reference :
If compatibility with legacy builds or versions of tools that don’t support certain packaging standards (e.g. PEP 517 or PEP 660), a simple setup.py script can be added to your project [1] (while keeping the configuration in pyproject.toml):
Discussed IRL with @lunika
There was a problem hiding this comment.
I know it fails without it. Not sure if there's another easier way...
| DATABASES = { | ||
| "default": { | ||
| "default": dj_database_url.config() | ||
| if environ.get("DATABASE_URL") |
There was a problem hiding this comment.
What do you think about using Django config values (e.g., values.Value(...)) to keep settings.py consistent?
There was a problem hiding this comment.
Nit: I prefer DATABASE_, but for consistency, should we stick with DB_ for all database-related settings?
There was a problem hiding this comment.
DATABASE_URL is a standard name in most PaaS platforms https://doc.scalingo.com/databases/postgresql/getting-started/connecting https://devcenter.heroku.com/changelog-items/438
| mv src/backend/* ./ | ||
| mv src/nginx/* ./ | ||
|
|
||
| echo "3.13" > .python-version No newline at end of file |
| @@ -0,0 +1,50 @@ | |||
|
|
|||
There was a problem hiding this comment.
Quick review, I agree with @lunika's comment. The src/nginx folder name doesn’t really communicate the purpose of this Nginx config. Could we at least add a short README in this folder to explain the overall PaaS deployment?
Also, just a note: /media and /media-auth are required in Meet for handling recordings!
There was a problem hiding this comment.
@lebaudantoine what about making a deploy folder and moving files from docker in there? suitenumerique/docs#1020 (comment)
This PR adds a new deployment option for Heroku-like platforms based on buildpacks, like Scalingo.
Similar deployments options are already supported in Messages, Drive and soon Docs suitenumerique/docs#1020