✨ List and restore deleted docs #1450

AntoLC · 2025-10-02T16:24:49Z

Purpose

We want to be able to see the deleted documents, and to restore them if needed.

Proposal

✨(frontend) add trashbin list
✨(frontend) can restore from trashbin list actions
✨(frontend) doc page when deleted

Demo

🚨 Take care

After TRASHBIN_CUTOFF_DAYS days, the doc will be definitively deleted, 30 by default.

docs/src/backend/impress/settings.py

Lines 430 to 432 in 9bb3f51

    
           TRASHBIN_CUTOFF_DAYS = values.Value( 
        
               30, environ_name="TRASHBIN_CUTOFF_DAYS", environ_prefix=None 
        
           )

github-actions · 2025-10-02T16:29:28Z

Size Change: +2.11 kB (+0.06%)

Total Size: 3.66 MB

Filename	Size	Change
`apps/impress/out/_next/static/4df21e30/_buildManifest.js`	0 B	-881 B (removed)	🏆
`apps/impress/out/_next/static/chunks/8495.js`	53.9 kB	+1.78 kB (+3.42%)
`apps/impress/out/_next/static/css/2ee6d170e518968d.css`	0 B	-25.4 kB (removed)	🏆
`apps/impress/out/_next/static/b42ccd61/_buildManifest.js`	882 B	+882 B (new file)	🆕
`apps/impress/out/_next/static/css/60e2be63c8d26a80.css`	25.4 kB	+25.4 kB (new file)	🆕

_{compressed-size-action}

AntoLC · 2025-10-08T13:46:13Z

You can test this feature now from https://1450-docs.ppr-docs.beta.numerique.gouv.fr/ !

Login: docs
Pass: docs

Ovgodd · 2025-10-09T09:10:17Z

hey @AntoLC This is pretty good I like it ! juste One thing :
In the deleted doc, when we tab from the doc : "test deletion" the focus goes on greyed subitem, it should go on the
Document deleted title then resterore button

tabfocu.mp4

Ovgodd

Nice ! I suggested some little things !

Ovgodd · 2025-10-09T09:14:52Z

src/frontend/apps/impress/src/features/docs/doc-tree/components/DocTree.tsx

-              const parentDoc = parentNode?.data.value as Doc;
-              if (!parentDoc) {
-                return currentDoc.abilities.move && isDesktop;
+          <Overlayer isOverlay={currentDoc.deleted_at != null}>


I think we can do this, avoiding the unwanted tabfocus into the greyed subitem,
But react thinks Inert is not valid html ,
So maybe we can add this too :

// global.d.ts declare module 'react' { interface HTMLAttributes<T> { inert?: '' | undefined; } }

Suggested change

<Overlayer isOverlay={currentDoc.deleted_at != null}>

<section

aria-disabled={!!doc.deleted_at}

{...(doc.deleted_at

? ({ inert: '' } satisfies React.HTMLAttributes<HTMLElement>)

: {})}

<Overlayer isOverlay={currentDoc.deleted_at != null}>

WDYT ? it is a proposition but I am not sure of it

Or I can look at the a11y of it after merging the main feature !

Ovgodd · 2025-10-09T09:23:59Z

src/frontend/apps/impress/src/features/docs/docs-grid/components/DocsGridItem.tsx

+  let dateToDisplay = relativeDate(doc.updated_at);
+
+  if (isInTrashbin && config?.TRASHBIN_CUTOFF_DAYS && doc.deleted_at) {
+    const daysLeft = calculateDaysLeft(
+      doc.deleted_at,
+      config.TRASHBIN_CUTOFF_DAYS,
+    );
+
+    dateToDisplay = `${daysLeft} ${t('days', { count: daysLeft })}`;
+  }


little suggestion, something like that for better readability ?

Suggested change

let dateToDisplay = relativeDate(doc.updated_at);

if (isInTrashbin && config?.TRASHBIN_CUTOFF_DAYS && doc.deleted_at) {

const daysLeft = calculateDaysLeft(

doc.deleted_at,

config.TRASHBIN_CUTOFF_DAYS,

);

dateToDisplay = `${daysLeft} ${t('days', { count: daysLeft })}`;

}

const shouldShowDaysLeft = isInTrashbin && config?.TRASHBIN_CUTOFF_DAYS && doc.deleted_at

const daysLeft =

shouldShowDaysLeft

? calculateDaysLeft(doc.deleted_at, config.TRASHBIN_CUTOFF_DAYS)

: null;

const dateToDisplay =

daysLeft !== null

? `${daysLeft} ${t('days', { count: daysLeft })}`

: relativeDate(doc.updated_at);

By doing shouldShowDaysLeft we get linter warning, the clear "if" condition helps the linter to know that doc.deleted_at is not undefined. I think it's ok, multiple ternaires do not improve a lot the readability.

To know when a document in the trashbin will be permanently deleted.

The front needs to know when a document has been deleted. We expose the deleted_at property on a document object,

The abilities for a deleted document were too open. We want to restrict them. Only the restore, retrieve and tree is allowed. The tree method will need some modifications to get the right informations.

The tree endpoint will now return a result only for owners. For other users the endpoint still returns a 403. Also, the endpoint does look for ancestors anymore, it only stay on the current document.

The design uses Material Symbols for icons. This commit adds the font to the project and updates the Icon component to be able to use it.

List the docs deleted in the trashbin list, it is displayed in the docs grid.

We can now restore a doc from the trashbin list actions.

Whe the doc is deleted, the doc page is a bit different, we have to adapt the doc header to add some information and actions that are relevant for a deleted doc.

We want to improve the accessibility of our BoxButton component by adding a theme focus visible style. This will help users who navigate using the keyboard to easily identify which button is currently focused. To do so we have to move some theme styles to the Box component to be able to use them in BoxButton.

AntoLC self-assigned this Oct 2, 2025

AntoLC added frontend feature add a new feature labels Oct 2, 2025

AntoLC marked this pull request as draft October 2, 2025 16:25

AntoLC force-pushed the feature/bin-in-docs branch 3 times, most recently from 6155329 to 9bb3f51 Compare October 3, 2025 11:03

AntoLC changed the title ~~feature/bin-in-docs~~ ✨ List and restore deleted docs Oct 3, 2025

AntoLC force-pushed the feature/bin-in-docs branch from 7616ea8 to a9be1c2 Compare October 7, 2025 07:41

AntoLC added the preview label Oct 7, 2025

AntoLC force-pushed the feature/bin-in-docs branch from 304c07c to 3ec8300 Compare October 8, 2025 13:01

AntoLC marked this pull request as ready for review October 8, 2025 13:01

AntoLC force-pushed the feature/bin-in-docs branch 3 times, most recently from 3256335 to 21e1bf6 Compare October 8, 2025 13:32

AntoLC force-pushed the feature/bin-in-docs branch 2 times, most recently from 6d6ef73 to 33928f0 Compare October 8, 2025 15:14

AntoLC requested a review from Ovgodd October 8, 2025 15:28

Ovgodd requested changes Oct 9, 2025

View reviewed changes

AntoLC mentioned this pull request Oct 9, 2025

✨(frontend) Can mask a document from the list view #1233

Closed

4 tasks

AntoLC and others added 7 commits October 10, 2025 09:53

🔧(backend) expose TRASHBIN_CUTOFF_DAYS

3dbd407

To know when a document in the trashbin will be permanently deleted.

✨(backend) expose deleted_at information in serializer

c878895

The front needs to know when a document has been deleted. We expose the deleted_at property on a document object,

♻️(backend) change abilities for deleted document

991ef19

The abilities for a deleted document were too open. We want to restrict them. Only the restore, retrieve and tree is allowed. The tree method will need some modifications to get the right informations.

♻️(backend) open tree endpoint to deleted documents only for owners

61f02dc

The tree endpoint will now return a result only for owners. For other users the endpoint still returns a 403. Also, the endpoint does look for ancestors anymore, it only stay on the current document.

🍱(frontend) add material-symbols-outlined font

cdc4f79

The design uses Material Symbols for icons. This commit adds the font to the project and updates the Icon component to be able to use it.

✨(frontend) add trashbin list

7d4810a

List the docs deleted in the trashbin list, it is displayed in the docs grid.

✨(frontend) can restore from trashbin list actions

a4f0ff3

We can now restore a doc from the trashbin list actions.

AntoLC added 2 commits October 10, 2025 09:53

✨(frontend) doc page when deleted

b5cb047

Whe the doc is deleted, the doc page is a bit different, we have to adapt the doc header to add some information and actions that are relevant for a deleted doc.

fixup! ✨(frontend) doc page when deleted

75935df

AntoLC force-pushed the feature/bin-in-docs branch from 33928f0 to d50d8b3 Compare October 10, 2025 08:36

AntoLC added 4 commits October 10, 2025 12:45

fixup! ✨(frontend) add trashbin list

704941a

fixup! ✨(frontend) can restore from trashbin list actions

84ce4f1

fixup! ✨(frontend) doc page when deleted

5af1da5

AntoLC force-pushed the feature/bin-in-docs branch from d50d8b3 to 5af1da5 Compare October 10, 2025 10:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

✨ List and restore deleted docs #1450

✨ List and restore deleted docs #1450

Uh oh!

AntoLC commented Oct 2, 2025 •

edited by rl-83

Loading

Uh oh!

github-actions bot commented Oct 2, 2025 •

edited

Loading

Uh oh!

AntoLC commented Oct 8, 2025

Uh oh!

Ovgodd commented Oct 9, 2025 •

edited

Loading

Uh oh!

Ovgodd left a comment

Uh oh!

Ovgodd Oct 9, 2025

Uh oh!

AntoLC Oct 10, 2025

Uh oh!

Ovgodd Oct 9, 2025

Uh oh!

AntoLC Oct 10, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	TRASHBIN_CUTOFF_DAYS = values.Value(
	30, environ_name="TRASHBIN_CUTOFF_DAYS", environ_prefix=None
	)

-          <Overlayer isOverlay={currentDoc.deleted_at != null}>
+<section
+  aria-disabled={!!doc.deleted_at}
+{...(doc.deleted_at
+  ? ({ inert: '' } satisfies React.HTMLAttributes<HTMLElement>)
+  : {})}
+  <Overlayer isOverlay={currentDoc.deleted_at != null}>

✨ List and restore deleted docs #1450

Are you sure you want to change the base?

✨ List and restore deleted docs #1450

Uh oh!

Conversation

AntoLC commented Oct 2, 2025 • edited by rl-83 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose

Proposal

Demo

🚨 Take care

Uh oh!

github-actions bot commented Oct 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AntoLC commented Oct 8, 2025

Uh oh!

Ovgodd commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Ovgodd left a comment

Choose a reason for hiding this comment

Uh oh!

Ovgodd Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

AntoLC Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

Ovgodd Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

AntoLC Oct 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

AntoLC commented Oct 2, 2025 •

edited by rl-83

Loading

github-actions bot commented Oct 2, 2025 •

edited

Loading

Ovgodd commented Oct 9, 2025 •

edited

Loading

AntoLC Oct 10, 2025 •

edited

Loading