Introduce atrium_api::types::Unknown for unknown fields
#205
Conversation
str4d
force-pushed
the
204-unknown-field-type
branch
from
2b17475 to
018fde6
Compare
str4d
force-pushed
the
204-unknown-field-type
branch
from
018fde6 to
e1d4b5c
Compare
| let typ = match name { | ||
| NamedUnknown::Field("didDoc") => quote!(crate::did_doc::DidDocument), | ||
| NamedUnknown::Field("record") | NamedUnknown::Array("relatedRecords") => { | ||
| quote!(crate::records::Record) |
There was a problem hiding this comment.
I figured that unknown fields named record or relatedRecords should still use Record, so after changing the default to Unknown I added these two extra cases, which affected the following lexicons: https://github.com/sugyan/atrium/compare/2b1747594b9e1fd711662416971c28c3cd7e1843..e1d4b5ca1e4c3ab9e891086bd4e2200c549ff742
| @@ -46,7 +46,7 @@ pub struct ViewRecordData { | |||
| pub repost_count: Option<i64>, | |||
| pub uri: String, | |||
| ///The record data itself. | |||
| pub value: crate::records::Record, | |||
| pub value: crate::types::Unknown, | |||
There was a problem hiding this comment.
Hmm, the moderation_quoteposts test now fails to compile because it expects a known record type here. Scanning over the other changes, it does seem that currently an unknown field named value is consistently a Record, but then why do the lexicons not use an open union?
I think we're going to need to ask for further guidance here. It might be that what we need to do, instead of my current changes, is to make UnknownData.type an Option<String> and then enforce that it is Some(_) everywhere that it is used for a union field.
There was a problem hiding this comment.
I've commented about the issue here: bluesky-social/atproto#999 (comment)
Closes #204.