Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Activity Section Layout and update CSS #594

Conversation

soumyaranjan-panda
Copy link
Contributor

Updated the activity section and added styling making it more interactive for teachers, students, and kids.

  • Added hover animation for interactive elements.
  • Tested responsiveness across different screen sizes.
  • Updated assets/activity-numbers.svg by removing unnecessary padding on the right and bottom sides.
  • Fixed background color inconsistency and merged activity website redirection section with main activity section making it feel cohesive.

@quozl
Copy link
Contributor

quozl commented Dec 15, 2024

Please update the icon in the Numbers activity, thanks.

@soumyaranjan-panda
Copy link
Contributor Author

Please update the icon in the Numbers activity, thanks.

Sorry, I didn’t quite understand your request. I have updated the number icon with the new one. Would you like me to revert it back, or is there another place where the icon needs to be updated?

@quozl
Copy link
Contributor

quozl commented Dec 16, 2024

Oh, you are so missing out. 😁

You will remember that your commit removed the HTML comment markers from the Numbers Activity elements. The button you have enabled links to 4336 in our Python 2 activity library. The entry in the library points to the GitHub repository for the activity, here. That repository has the icon in the activity directory.

So if you're proposing to change that icon, we'd expect you to change it in the activity as well as the web site. We chose not to automate the fetch or use git submodules.

See also #591 for problems with the section you are proposing to change.

@quozl
Copy link
Contributor

quozl commented Dec 16, 2024

https://v4.activities.sugarlabs.org/?q=numbers ... is another site where the icon is rendered, you can see the impact on the layout, but this will be fixed once the next release of the Numbers Activity is made after your change there.

@soumyaranjan-panda
Copy link
Contributor Author

Oh, you are so missing out. 😁

I thought I might need to change the icon in the number activity, but I just wanted to confirm if that’s what you had in mind. Thank you so much for your guidance!

@pikurasa pikurasa changed the title Refractor Activity Section Layout and update CSS Refactor Activity Section Layout and update CSS Dec 16, 2024
@quozl
Copy link
Contributor

quozl commented Dec 16, 2024

Thanks.

  • please remove the merge commit,
  • please rebase on the master branch, as it has since shifted.

@soumyaranjan-panda
Copy link
Contributor Author

I will create a new pull request to address all the issues.

@soumyaranjan-panda soumyaranjan-panda deleted the update-activity-section branch December 16, 2024 20:07
@quozl
Copy link
Contributor

quozl commented Dec 16, 2024

Why? Please learn how to resolve these issues without creating a new pull request. It is straightforward. It is difficult to track review comments across multiple pull requests.

@soumyaranjan-panda
Copy link
Contributor Author

Why? Please learn how to resolve these issues without creating a new pull request. It is straightforward. It is difficult to track review comments across multiple pull requests.

Yes, sir. This will be the last time I create a new pull request. Moving forward, I will ensure all issues are resolved within the same pull request. However, since I have already deleted the branch, it would be difficult to recover it. May I create another pull request to address this?

@quozl
Copy link
Contributor

quozl commented Dec 16, 2024

9594535 still exists, so recreating the branch shouldn't be hard. git checkout -b update-activity-section 9594535191e4b876e870d7e17ced69ad6a15dc44

@soumyaranjan-panda soumyaranjan-panda restored the update-activity-section branch December 16, 2024 20:30
@soumyaranjan-panda soumyaranjan-panda deleted the update-activity-section branch December 16, 2024 20:58
@soumyaranjan-panda soumyaranjan-panda restored the update-activity-section branch December 16, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants