-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Activity Section Layout and update CSS #594
Refactor Activity Section Layout and update CSS #594
Conversation
Please update the icon in the Numbers activity, thanks. |
Sorry, I didn’t quite understand your request. I have updated the number icon with the new one. Would you like me to revert it back, or is there another place where the icon needs to be updated? |
Oh, you are so missing out. 😁 You will remember that your commit removed the HTML comment markers from the Numbers Activity elements. The button you have enabled links to 4336 in our Python 2 activity library. The entry in the library points to the GitHub repository for the activity, here. That repository has the icon in the activity directory. So if you're proposing to change that icon, we'd expect you to change it in the activity as well as the web site. We chose not to automate the fetch or use git submodules. See also #591 for problems with the section you are proposing to change. |
https://v4.activities.sugarlabs.org/?q=numbers ... is another site where the icon is rendered, you can see the impact on the layout, but this will be fixed once the next release of the Numbers Activity is made after your change there. |
I thought I might need to change the icon in the number activity, but I just wanted to confirm if that’s what you had in mind. Thank you so much for your guidance! |
Thanks.
|
I will create a new pull request to address all the issues. |
Why? Please learn how to resolve these issues without creating a new pull request. It is straightforward. It is difficult to track review comments across multiple pull requests. |
Yes, sir. This will be the last time I create a new pull request. Moving forward, I will ensure all issues are resolved within the same pull request. However, since I have already deleted the branch, it would be difficult to recover it. May I create another pull request to address this? |
9594535 still exists, so recreating the branch shouldn't be hard. |
Updated the activity section and added styling making it more interactive for teachers, students, and kids.