Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement for service section #585

Closed
wants to merge 0 commits into from
Closed

Conversation

Devmoni
Copy link
Contributor

@Devmoni Devmoni commented Dec 13, 2024

Description:

This PR enhances the responsiveness and styling of the service section by ensuring equal-sized boxes, centered content, and consistent spacing.

Screenshot:

image

Testing:

Verified changes on a local Linux-based environment.

css/airspace.css Outdated
@@ -227,7 +227,18 @@ font header .navbar-default .navbar-nav li a:hover {
padding: 90px 0;
}
#service .service-item {
padding-bottom: 30px;
display: flex;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're trying to put new CSS into custom.css as to not confuse future maintainers.

Please solve this in a way that doesn't change the mainstream airspace.css file.

@Devmoni Devmoni requested a review from pikurasa December 14, 2024 03:38
css/custom.css Outdated
max-width: 25%;
flex: 0 0 25%;
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing newline at end of file.

@quozl
Copy link
Contributor

quozl commented Dec 14, 2024

Your commit message does not follow our guidance. In particular, you have placed in the pull request opening text that would be better in the commit message.

@Devmoni Devmoni requested a review from quozl December 14, 2024 05:53
@quozl quozl mentioned this pull request Dec 14, 2024
6 tasks
@quozl
Copy link
Contributor

quozl commented Dec 14, 2024

Thanks. Good progress. Please squash the commits and rewrite the commit message as mentioned.

@quozl
Copy link
Contributor

quozl commented Dec 15, 2024

Forward link; this pull request was replaced by #592

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants