Open
Conversation
anjali-deshpande-hub
suggested changes
May 14, 2025
anjali-deshpande-hub
left a comment
anjali-deshpande-hub
left a comment
There was a problem hiding this comment.
Looks good! Just one change is required:
Replace the hardcoded absolute paths to relative paths so that a Learning support can run the code successfully as well. For example: change r"C:\users\Suchi\Python\05_src\data\assignment_2_data\inflammation_01.csv" to r"..\..\05_src\data\assignment_2_data\inflammation_01.csv"
The indentations of the some of the strings is off too.
Owner
Author
|
hi Anjali,
I've made changes to the file and committed them again. Please verify and
let me know.
Assignment-2 changes made by Sucharitha by suchi-dev-ai · Pull Request #2 ·
suchi-dev-ai/python <#2>
…On Tue, 13 May 2025 at 23:14, anjali-deshpande-hub ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Looks good! Just one change is required:
Replace the hardcoded absolute paths to relative paths so that a Learning
support can run the code successfully as well. For example: change
r"C:\users\Suchi\Python\05_src\data\assignment_2_data\inflammation_01.csv"
to r"..\..\05_src\data\assignment_2_data\inflammation_01.csv"
The indentations of the some of the strings is off too.
—
Reply to this email directly, view it on GitHub
<#2 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARS52ARNERZE3SSFOZY6MZD26KYKNAVCNFSM6AAAAAB4274HNKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDQMZYGYYDANJSG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
anjali-deshpande-hub
approved these changes
May 21, 2025
anjali-deshpande-hub
left a comment
anjali-deshpande-hub
left a comment
There was a problem hiding this comment.
The path is corrected for inflammation_01.csv. The other paths will give you error if tested.
The indentation of some strings is still off. But that's not a biggie.
I will accept the changes
Owner
Author
|
Hi Anjali,
Thanks, i just noticed I copied it wrong for the rest of the files.Sorry
about that. I'll fix that. Thanks for checking again.
Sorry for the trouble.
Thanks,
Sucharitha
…On Wed, 21 May 2025, 16:27 anjali-deshpande-hub, ***@***.***> wrote:
***@***.**** approved this pull request.
The path is corrected for inflammation_01.csv. The other paths will give
you error if tested.
The indentation of some strings is still off. But that's not a biggie.
I will accept the changes
—
Reply to this email directly, view it on GitHub
<#2 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARS52ASVK2JQGWC4MP7BMCD27TORJAVCNFSM6AAAAAB4274HNKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDQNJZGAZDMNRVGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.