fix: pin @opentui/core to 0.1.72 to prevent symbol mismatch#313
fix: pin @opentui/core to 0.1.72 to prevent symbol mismatch#313thunter009 wants to merge 1 commit intosubsy:mainfrom
Conversation
The caret range ^0.1.72 resolves to 0.1.80 which renamed setCursorStyle → setCursorStyleOptions in the native dylib. The bundled JS bindings still reference setCursorStyle, causing a crash on startup. Pinning to exact 0.1.72 until the bundled bindings are rebuilt against the latest @opentui/core. Fixes subsy#312 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
@thunter009 is attempting to deploy a commit to the plgeek Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughDependency version specifiers for Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
package.json (1)
73-74: Pin is the correct stopgap; track the long-term rebuild.The exact version pin correctly prevents
^0.1.72from resolving to0.1.80, where the native dylib renamedsetCursorStyle→setCursorStyleOptions.@opentui/react@0.1.72itself declares@opentui/core: "0.1.72"as a pinned dependency, so there is no transitive re-escalation risk from the@opentui/reactside. The current latest@opentui/coreis0.1.80with no known vulnerabilities, so staying on0.1.72is safe from a security standpoint for now.Consider opening a tracking issue (or referencing
#312explicitly) to ensure the long-term fix — rebuildingdist/index.jsagainst@opentui/core@0.1.80and lifting this pin — is not forgotten as the upstream package continues to evolve rapidly.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@package.json` around lines 73 - 74, The dependency pin for "@opentui/core": "0.1.72" prevents accidental upgrade to 0.1.80 which renamed setCursorStyle → setCursorStyleOptions; keep the pin as the short-term mitigation but open a tracking issue (reference `#312`) to rebuild dist/index.js against `@opentui/core`@0.1.80, update `@opentui/core` in package.json and lift the version pin once the library is rebuilt and tested, and ensure `@opentui/react` (still at "0.1.72") remains compatible after the rebuild.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@package.json`:
- Around line 73-74: The dependency pin for "@opentui/core": "0.1.72" prevents
accidental upgrade to 0.1.80 which renamed setCursorStyle →
setCursorStyleOptions; keep the pin as the short-term mitigation but open a
tracking issue (reference `#312`) to rebuild dist/index.js against
`@opentui/core`@0.1.80, update `@opentui/core` in package.json and lift the version
pin once the library is rebuilt and tested, and ensure `@opentui/react` (still at
"0.1.72") remains compatible after the rebuild.
|
Closing as fiixed properly in #315 - thanks @thunter009 for flagging this |
Summary
@opentui/coreand@opentui/reactfrom^0.1.72to exact0.1.72setCursorStyle→setCursorStyleOptionsin the native dylib, crashing ralph-tui on startupContext
The bundled
dist/index.jshas FFI bindings that callsetCursorStyle(renderer, style, blinking). In@opentui/core-darwin-arm64@0.1.80, this symbol was renamed tosetCursorStyleOptionswith a different calling convention (options struct). Pinning to 0.1.72 is a stopgap; longer-term fix is rebuilding the bundle against 0.1.80.Fixes #312
🤖 Generated with Claude Code
Summary by CodeRabbit