Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
85 changes: 85 additions & 0 deletions src/plugins/agents/builtin/claude.ts
Original file line number Diff line number Diff line change
Expand Up @@ -534,6 +534,91 @@ export class ClaudeAgentPlugin extends BaseAgentPlugin {
return null;
}

/**
* Override preflight to add --max-turns 1 for faster, more reliable checks.
* Without --max-turns, Claude may run multiple turns which can exceed the timeout.
*/
override async preflight(
options?: { timeout?: number }
): Promise<import('../types.js').AgentPreflightResult> {
const startTime = Date.now();
const timeout = options?.timeout ?? 15000;

try {
// First ensure detect passes
const detection = await this.detect();
if (!detection.available) {
return {
success: false,
error: detection.error ?? 'Agent not available',
suggestion: `Make sure ${this.meta.name} is installed and accessible`,
durationMs: Date.now() - startTime,
};
}

// Run a minimal test prompt with --max-turns 1 for quick response
const testPrompt = 'Respond with exactly: PREFLIGHT_OK';
let output = '';

const handle = this.execute(testPrompt, [], {
timeout,
flags: ['--max-turns', '1'],
onStdout: (data: string) => {
output += data;
},
});

const result = await handle.promise;
const durationMs = Date.now() - startTime;

// Check if we got any meaningful response
if (result.status === 'completed' && output.length > 0) {
return {
success: true,
durationMs,
};
}

if (result.status === 'timeout') {
return {
success: false,
error: 'Agent timed out without responding',
suggestion: this.getPreflightSuggestion(),
durationMs,
};
}

if (result.status === 'failed') {
// Include exit code and stderr for debugging
const details = [
result.error,
result.exitCode !== undefined ? `exit code: ${result.exitCode}` : null,
result.stderr ? `stderr: ${result.stderr.slice(0, 200)}` : null,
].filter(Boolean).join(', ');
return {
success: false,
error: details || 'Agent execution failed',
suggestion: this.getPreflightSuggestion(),
durationMs,
};
}

return {
success: false,
error: 'Agent did not produce any output',
suggestion: this.getPreflightSuggestion(),
durationMs,
};
} catch (error) {
return {
success: false,
error: error instanceof Error ? error.message : String(error),
suggestion: this.getPreflightSuggestion(),
durationMs: Date.now() - startTime,
};
}
}

/**
* Get Claude-specific suggestions for preflight failures.
* Provides actionable guidance for common configuration issues.
Expand Down