Skip to content

style: add final modifier where possible #629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nielspardon wants to merge 1 commit into
base: main
Choose a base branch
from
Open

style: add final modifier where possible #629

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions build-logic/src/main/resources/substrait-pmd.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@

<rule ref="category/java/codestyle.xml/UnnecessaryModifier" />
<rule ref="category/java/codestyle.xml/FieldDeclarationsShouldBeAtStartOfClass" />
<rule ref="category/java/codestyle.xml/FinalParameterInAbstractMethod" />
<rule ref="category/java/codestyle.xml/LocalVariableCouldBeFinal" />
<rule ref="category/java/codestyle.xml/MethodArgumentCouldBeFinal" />
Copy link
Member

@benbellick benbellick Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am definitely in favor of the first two FinalParameterInAbstractMethod and LocalVariableCouldBeFinal, but I am less convinced about introducing MethodArgumentCouldBeFinal. It looks like a lot noise is introduced in this PR by bringing in that rule. Considering that usage of final doesn't actually prevent mutation of the object, just reassignment to a new object, it doesn't seem that useful.

We also already have the immutables library to protect against mutation for the classes for which that matters.

Happy to be convinced though if there is a compelling reason to switch to using final.

<rule ref="category/java/codestyle.xml/UseExplicitTypes" />
<rule ref="category/java/bestpractices.xml/JUnit5TestShouldBePackagePrivate" />
<rule ref="category/java/bestpractices.xml/MissingOverride" />
Expand Down
Loading