Skip to content

ci: handle warnings in compileScala as errors #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2025
Merged

ci: handle warnings in compileScala as errors #519

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion spark/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,9 @@ java {
withSourcesJar()
}

tasks.withType<ScalaCompile>() { scalaCompileOptions.additionalParameters = listOf("-release:17") }
tasks.withType<ScalaCompile>() {
scalaCompileOptions.additionalParameters = listOf("-release:17", "-Xfatal-warnings")
}

var SPARKBUNDLE_VERSION = properties.get("sparkbundle.version")

Expand Down
2 changes: 2 additions & 0 deletions spark/src/main/scala/io/substrait/spark/logical/ToLogicalPlan.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ import io.substrait.relation.files.FileFormat
import io.substrait.util.EmptyVisitationContext
import org.apache.hadoop.fs.Path

import scala.annotation.nowarn
import scala.collection.JavaConverters.asScalaBufferConverter
import scala.collection.mutable.ArrayBuffer

Expand Down Expand Up @@ -180,6 +181,7 @@ class ToLogicalPlan(spark: SparkSession = SparkSession.builder().getOrCreate())
}
}

@nowarn("cat=deprecation")
override def visit(join: relation.Join, context: EmptyVisitationContext): LogicalPlan = {
val left = join.getLeft.accept(this, context)
val right = join.getRight.accept(this, context)
Expand Down